Skip to content

fix(db-postgres): reordering of enum values, bump drizzle-kit@0.31.0 and drizzle-orm@0.43.1#12256

Merged
DanRibbens merged 7 commits intomainfrom
fix/drizzle
Jun 16, 2025
Merged

fix(db-postgres): reordering of enum values, bump drizzle-kit@0.31.0 and drizzle-orm@0.43.1#12256
DanRibbens merged 7 commits intomainfrom
fix/drizzle

Conversation

@r1tsuu
Copy link
Copy Markdown
Member

@r1tsuu r1tsuu commented Apr 29, 2025

Fixes the issue when reordering select field options in postgres by bumping drizzle-kit and drizzle-orm, related PR drizzle-team/drizzle-orm#4330

cannot drop type enum_users_select because other objects depend on it

fixes #8544

Copy link
Copy Markdown
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the tests pass, we can merge this. I've tested on other minor versions from drizzle recently and didn't come across any issues. It seems they are doing a good job not introducing breaking changes.

Copy link
Copy Markdown
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the failed tests. It looks like there are some differences this time around.

@r1tsuu r1tsuu marked this pull request as ready for review April 29, 2025 15:16
DanRibbens
DanRibbens previously approved these changes Apr 29, 2025
Copy link
Copy Markdown
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the quick fix!

DanRibbens
DanRibbens previously approved these changes Jun 16, 2025
@DanRibbens DanRibbens enabled auto-merge (squash) June 16, 2025 17:56
Copy link
Copy Markdown
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests pass, then I think we can force merge after we adjust the variable name to get the release out.

Comment thread package.json
"dotenv": "16.4.7",
"drizzle-kit": "0.28.0",
"drizzle-kit": "0.31.0",
"drizzle-orm": "0.43.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this was not here before.

Comment thread packages/drizzle/src/upsertRow/index.ts Outdated
// Error Handling
// //////////////////////////////////
} catch (error) {
} catch (catchedError) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caughtError is what I would go with here.

@r1tsuu r1tsuu requested a review from DanRibbens June 16, 2025 19:12
@DanRibbens DanRibbens disabled auto-merge June 16, 2025 20:03
@DanRibbens DanRibbens merged commit 7045182 into main Jun 16, 2025
75 checks passed
@DanRibbens DanRibbens deleted the fix/drizzle branch June 16, 2025 20:03
@github-actions
Copy link
Copy Markdown
Contributor

🚀 This is included in version v3.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants